Add PickerAvoidingView and PickerStateProvider for better iOS modal handling#11
Closed
jakub-trzebiatowski wants to merge 4 commits intoExpensify:masterfrom
Closed
Add PickerAvoidingView and PickerStateProvider for better iOS modal handling#11jakub-trzebiatowski wants to merge 4 commits intoExpensify:masterfrom
PickerAvoidingView and PickerStateProvider for better iOS modal handling#11jakub-trzebiatowski wants to merge 4 commits intoExpensify:masterfrom
Conversation
...which provide tools for ensuring that a picker is not covered by its own modal on iOS.
...to give a more visually pleasant effect.
Julesssss
reviewed
Apr 14, 2023
Comment on lines
+253
to
+257
| setTimeout(() => { | ||
| this.props.scrollViewRef.current.scrollTo({ | ||
| y: textInputBottomY - modalY + 10 + this.props.scrollViewContentOffsetY, | ||
| }); | ||
| }, IOS_MODAL_ANIMATION_DURATION_MS + 50); |
There was a problem hiding this comment.
Can we figure out a way of avoiding the setTimeout? Possible via a hook?
Author
There was a problem hiding this comment.
This PR was filed by mistake. It was meant for the upstream. I fixed that. Upstream PR: lawnstarter#507
Author
|
PR filed by mistake, was meant for the upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two new components,
PickerAvoidingViewandPickerStateProvider. These components aim to improve the user experience on iOS by ensuring that the picker is not obstructed by its own modal. The PickerAvoidingView handles proper positioning of the picker, while the PickerStateProvider manages the state and interactions between multiple pickers. This update enhances the overall usability of the picker component on iOS devices.Note: This PR is stacked on top of lawnstarter#496, so that one needs to be merged first